r107345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107344‎ | r107345 | r107346 >
Date:22:35, 26 December 2011
Author:jarry1250
Status:deferred
Tags:
Comment:
Followup r107239 per Krinkle: pass id to $.createSpinner, and no need to set id of temp, just use variable instead.
Modified paths:
  • /trunk/extensions/TranslateSvg/ext.translateSvg.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TranslateSvg/ext.translateSvg.core.js
@@ -35,7 +35,7 @@
3636 }
3737 $( '#specialtranslatesvg' ).prepend( getNewFieldset( langcode, languages[langcode] ) );
3838 } else {
39 - var temp = $( '<fieldset class="mw-translatesvg-temp"><br /></fieldset>' ).append( $.createSpinner() );
 39+ var temp = $( '<fieldset><br /></fieldset>' ).append( $.createSpinner( 'translatesvg-temp') );
4040 $( '#specialtranslatesvg' ).prepend( temp );
4141 jQuery.getJSON(
4242 mw.util.wikiScript( 'api' ), {
@@ -54,7 +54,7 @@
5555 //Have now loaded valid languages and this ain't one of them
5656 //TODO: more helpful?
5757 }
58 - $( '.mw-translatesvg-temp' ).remove();
 58+ temp.remove();
5959 languages.isset = true;
6060 }
6161 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107239Fix per SPQRobin: Internationalise thumb alignment; Fix very poor step checki...jarry125023:19, 24 December 2011

Status & tagging log