r107240 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107239‎ | r107240 | r107241 >
Date:23:20, 24 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r106235

Exploding $formData['member'] to then just append anyway seems a bit silly

Use the loops $member value
Modified paths:
  • /trunk/extensions/OpenStackManager/special/SpecialNovaProject.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaProject.php
@@ -318,7 +318,7 @@
319319 $project = OpenStackNovaProject::getProjectByName( $formData['projectname'] );
320320 $members = explode( ',', $formData['member'] );
321321 foreach ( $members as $member ) {
322 - $project->addMember( $formData['member'] );
 322+ $project->addMember( $member );
323323 }
324324 $roles = $project->getRoles();
325325 foreach ( $roles as $role ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106235Add membership and role dialog to project creation.laner19:35, 14 December 2011

Status & tagging log