r107184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107183‎ | r107184 | r107185 >
Date:21:24, 23 December 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Removing global usage in the global scope
Modified paths:
  • /trunk/extensions/ConfirmEdit/ConfirmEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmEdit/ConfirmEdit.php
@@ -34,8 +34,6 @@
3535 exit;
3636 }
3737
38 -global $wgExtensionFunctions, $wgGroupPermissions;
39 -
4038 $wgExtensionFunctions[] = 'confirmEditSetup';
4139 $wgExtensionCredits['other'][] = array(
4240 'path' => __FILE__,
@@ -71,7 +69,6 @@
7270 */
7371 $wgCaptchaWhitelistIP = false;
7472
75 -global $wgCaptcha, $wgCaptchaClass, $wgCaptchaTriggers;
7673 $wgCaptcha = null;
7774 $wgCaptchaClass = 'SimpleCaptcha';
7875
@@ -121,7 +118,6 @@
122119 * 'CaptchaCacheStore' uses $wgMemc, which avoids the cookie dependency
123120 * but may be fragile depending on cache configuration.
124121 */
125 -global $wgCaptchaStorageClass;
126122 $wgCaptchaStorageClass = 'CaptchaSessionStore';
127123
128124 /**
@@ -130,7 +126,6 @@
131127 *
132128 * Default is a half hour.
133129 */
134 -global $wgCaptchaSessionExpiration;
135130 $wgCaptchaSessionExpiration = 30 * 60;
136131
137132 /**
@@ -142,21 +137,18 @@
143138 *
144139 * Default is five minutes.
145140 */
146 -global $wgCaptchaBadLoginExpiration;
147141 $wgCaptchaBadLoginExpiration = 5 * 60;
148142
149143 /**
150144 * Allow users who have confirmed their e-mail addresses to post
151145 * URL links without being harassed by the captcha.
152146 */
153 -global $ceAllowConfirmedEmail;
154147 $ceAllowConfirmedEmail = false;
155148
156149 /**
157150 * Number of bad login attempts before triggering the captcha. 0 means the
158151 * captcha is presented on the first login.
159152 */
160 -global $wgCaptchaBadLoginAttempts;
161153 $wgCaptchaBadLoginAttempts = 3;
162154
163155 /**

Status & tagging log