r107166 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107165‎ | r107166 | r107167 >
Date:18:03, 23 December 2011
Author:grafzahl
Status:ok
Tags:
Comment:
Completing documentation
Modified paths:
  • /trunk/extensions/Score/Score.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Score/Score.body.php
@@ -67,7 +67,7 @@
6868 const LILYPOND_DIR_NAME = 'lilypond';
6969
7070 /**
71 - * Supported score languages
 71+ * Supported score languages.
7272 */
7373 private static $supportedLangs = array( 'lilypond', 'ABC' );
7474
@@ -142,10 +142,10 @@
143143 /**
144144 * Renders the score code (LilyPond, ABC, etc.) in a <score>…</score> tag.
145145 *
146 - * @param $code
147 - * @param $args
148 - * @param $parser
149 - * @param $frame
 146+ * @param $code score code.
 147+ * @param $args array of score tag attributes.
 148+ * @param $parser Parser of Mediawiki.
 149+ * @param $frame PPFrame expansion frame, not used by this extension.
150150 *
151151 * @return Image link HTML, and possibly anchor to MIDI file.
152152 */
@@ -392,8 +392,8 @@
393393 /**
394394 * Embeds simple LilyPond code in a score block.
395395 *
396 - * @param $lilypondCode
397 - * @param $options
 396+ * @param $lilypondCode simple LilyPond code.
 397+ * @param $options rendering options, see Score::generateHTML() for explanation.
398398 *
399399 * @return Raw lilypond code.
400400 *
@@ -519,8 +519,8 @@
520520 /**
521521 * Trims an image with ImageMagick.
522522 *
523 - * @param $source
524 - * @param $dest
 523+ * @param $source path to the source image.
 524+ * @param $dest path to the target (trimmed) image.
525525 *
526526 * @throws ScoreException on error.
527527 */
@@ -541,7 +541,7 @@
542542 /**
543543 * Deletes a directory with no subdirectories with all files in it.
544544 *
545 - * @param $dir
 545+ * @param $dir path to the directory that is to be deleted.
546546 *
547547 * @return true on success, false on error
548548 */
@@ -563,7 +563,7 @@
564564 /**
565565 * Writes the specified message to the Score debug log.
566566 *
567 - * @param $msg
 567+ * @param $msg message to log.
568568 */
569569 private static function debug( $msg ) {
570570 wfDebugLog( 'Score', $msg );

Status & tagging log