r107161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107160‎ | r107161 | r107162 >
Date:15:31, 23 December 2011
Author:maxsem
Status:ok
Tags:
Comment:
Follow-up r107160: killed another indexExists()
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
@@ -127,15 +127,13 @@
128128 true
129129 ) );
130130
131 - if ( !$db->indexExists( 'article_feedback', 'aa_page_id', __METHOD__ ) ) {
132 - $updater->addExtensionUpdate( array(
133 - 'addIndex',
134 - 'article_feedback',
135 - 'aa_page_id',
136 - $dir . '/sql/AddArticleFeedbackPageIndex.sql',
137 - true
138 - ) );
139 - }
 131+ $updater->addExtensionUpdate( array(
 132+ 'addIndex',
 133+ 'article_feedback',
 134+ 'aa_page_id',
 135+ $dir . '/sql/AddArticleFeedbackPageIndex.sql',
 136+ true
 137+ ) );
140138
141139 $updater->addExtensionUpdate( array(
142140 'addField',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107160Ditched pre-1.17 compat code, fixed updater. The whole point of the updates l...maxsem15:17, 23 December 2011

Status & tagging log