r107141 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107140‎ | r107141 | r107142 >
Date:08:56, 23 December 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Typos, code conventions
Modified paths:
  • /trunk/extensions/MarkAsHelpful/includes/MarkAsHelpfulItem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MarkAsHelpful/includes/MarkAsHelpfulItem.php
@@ -49,7 +49,7 @@
5050 /**
5151 * Setter method
5252 * @param $key string - the name of the property
53 - * @param $value mixed - the valud of the property
 53+ * @param $value mixed - the value of the property
5454 */
5555 public function setProperty( $key, $value ) {
5656 if ( array_key_exists( $key, $this->property ) ) {
@@ -201,8 +201,8 @@
202202 }
203203
204204 /**
205 - * Unmark an item as helpful, we don't allow anonymous user to unarmk an item
206 - * @param $currentUser Object - the current user who is browsing the site
 205+ * Unmark an item as helpful, we don't allow anonymous user to unmark an item
 206+ * @param $currentUser User - the current user who is browsing the site
207207 */
208208 public function unmark( $currentUser ) {
209209
@@ -263,7 +263,7 @@
264264 $conds['mah_user_id'] = 0;
265265 } else {
266266 $conds['mah_user_id'] = $user->getId();
267 - $conds['mah_user_ip'] = NULL;
 267+ $conds['mah_user_ip'] = null;
268268 }
269269 } else {
270270 // Invalid User object, we can't allow this user to mark an item
@@ -310,7 +310,7 @@
311311
312312 $list = array();
313313
314 - foreach ( $res AS $val ) {
 314+ foreach ( $res as $val ) {
315315 $list[$val->user_id] = array( 'user_name' => $val->user_name,
316316 'user_id' => $val->user_id,
317317 'user_ip' => $val->mah_user_ip );

Status & tagging log