| Index: trunk/phase3/tests/phpunit/includes/HttpTest.php |
| — | — | @@ -124,6 +124,14 @@ |
| 125 | 125 | ); |
| 126 | 126 | } |
| 127 | 127 | |
| | 128 | + /** |
| | 129 | + * Warning: |
| | 130 | + * |
| | 131 | + * These tests are for code that makes use of an artifact of how CURL |
| | 132 | + * handles header reporting on redirect pages, and will need to be |
| | 133 | + * rewritten when bug 29232 is taken care of (high-level handling of |
| | 134 | + * HTTP redirects). |
| | 135 | + */ |
| 128 | 136 | function testRelativeRedirections() { |
| 129 | 137 | $h = new MWHttpRequestTester( 'http://oldsite/file.ext' ); |
| 130 | 138 | # Forge a Location header |
| Index: trunk/phase3/includes/HttpFunctions.php |
| — | — | @@ -591,6 +591,10 @@ |
| 592 | 592 | * Relative values of the "Location" header are incorrect as stated in RFC, however they do happen and modern browsers support them. |
| 593 | 593 | * This function loops backwards through all locations in order to build the proper absolute URI - Marooned at wikia-inc.com |
| 594 | 594 | * |
| | 595 | + * Note that the multiple Location: headers are an artifact of CURL -- they |
| | 596 | + * shouldn't actually get returned this way. Rewrite this when bug 29232 is |
| | 597 | + * taken care of (high-level redirect handling rewrite). |
| | 598 | + * |
| 595 | 599 | * @return string |
| 596 | 600 | */ |
| 597 | 601 | public function getFinalUrl() { |