r107104 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107103‎ | r107104 | r107105 >
Date:20:00, 22 December 2011
Author:grafzahl
Status:deferred
Tags:score 
Comment:
Use original code as image alt text whenever we have single-image results
Modified paths:
  • /trunk/extensions/Score/Score.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Score/Score.body.php
@@ -168,10 +168,8 @@
169169 case 'lilypond':
170170 if ( !array_key_exists( 'raw', $args ) || !$args['raw'] ) {
171171 $lilypondCode = self::embedLilypondCode( $code, $renderMidi );
172 - $altText = $code;
173172 } else {
174173 $lilypondCode = $code;
175 - $altText = false;
176174 }
177175 self::createFactory( $factoryDirectory );
178176 $rc = file_put_contents( $lilypondFile, $lilypondCode );
@@ -180,7 +178,6 @@
181179 }
182180 break;
183181 case 'ABC':
184 - $altText = false;
185182 self::runAbc2Ly( $code, $factoryDirectory );
186183 break;
187184 default:
@@ -188,7 +185,7 @@
189186 }
190187
191188 /* Run LilyPond */
192 - $html = self::runLilypond( $factoryDirectory, $renderMidi, $altText );
 189+ $html = self::runLilypond( $factoryDirectory, $renderMidi, $code );
193190 } catch ( ScoreException $e ) {
194191 self::eraseFactory( $factoryDirectory );
195192 return $e;

Sign-offs

UserFlagDate
Nikerabbitinspected13:50, 23 December 2011
😂inspected18:02, 24 December 2011

Status & tagging log