r107101 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107100‎ | r107101 | r107102 >
Date:19:52, 22 December 2011
Author:laner
Status:ok
Tags:
Comment:
Add warning about puppet configuration on instance creation.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackManager.i18n.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php
@@ -297,6 +297,13 @@
298298 }
299299
300300 function setPuppetInfo( &$instanceInfo, $puppetinfo=array() ) {
 301+ if ( !$puppetinfo ) {
 302+ $instanceInfo["warning"] = array(
 303+ 'type' => 'info',
 304+ 'section' => "instance/puppetinfo",
 305+ 'default' => wfMsg( 'openstackmanager-createinstancepuppetwarning' ),
 306+ );
 307+ }
301308 $puppetGroups = OpenStackNovaPuppetGroup::getGroupList();
302309 foreach ( $puppetGroups as $puppetGroup ) {
303310 $classes = array();
Index: trunk/extensions/OpenStackManager/OpenStackManager.i18n.php
@@ -100,6 +100,7 @@
101101
102102 'openstackmanager-launchtime' => 'Launch time',
103103 'openstackmanager-createinstance' => 'Create a new instance',
 104+ 'openstackmanager-createinstancepuppetwarning' => 'Warning: Adding puppet configuration on instance creation can cause the instance to fail to build. Use this configuration with caution. You will have an opportunity to configure the instance after it is finished building.',
104105 'openstackmanager-invaliddomain' => 'Requested domain is invalid.',
105106 'openstackmanager-createdinstance' => 'Created instance $1 with image $2 and hostname $3.',
106107 'openstackmanager-createfailedldap' => 'Failed to create instance as the host could not be added to LDAP.',

Status & tagging log