r107089 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107088‎ | r107089 | r107090 >
Date:18:52, 22 December 2011
Author:catrope
Status:ok
Tags:
Comment:
Define $wgMarkAsHelpfulType in the setup file to prevent register_global scares. Also fix some typos
Modified paths:
  • /trunk/extensions/MarkAsHelpful/MarkAsHelpful.hooks.php (modified) (history)
  • /trunk/extensions/MarkAsHelpful/MarkAsHelpful.php (modified) (history)
  • /trunk/extensions/MarkAsHelpful/api/ApiMarkAsHelpful.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MarkAsHelpful/MarkAsHelpful.php
@@ -8,6 +8,10 @@
99 die();
1010 }
1111
 12+// Configuration
 13+// TODO: document
 14+$wgMarkAsHelpfulType = array();
 15+
1216 // Extension credits that will show up on Special:Version
1317 $wgExtensionCredits['other'][] = array(
1418 'path' => __FILE__,
Index: trunk/extensions/MarkAsHelpful/MarkAsHelpful.hooks.php
@@ -29,7 +29,7 @@
3030 /**
3131 * Runs MarkAsHelpful schema updates#
3232 *
33 - * @param $updater DatabasEUpdater
 33+ * @param $updater DatabaseUpdater
3434 */
3535 public static function onLoadExtensionSchemaUpdates( $updater = null ) {
3636 $updater->addExtensionTable( 'mark_as_helpful', dirname( __FILE__ ) . '/sql/mark_as_helpful.sql' );
Index: trunk/extensions/MarkAsHelpful/api/ApiMarkAsHelpful.php
@@ -13,7 +13,7 @@
1414
1515 $isAbleToMark = true;
1616
17 - // Gives other extension the last chance to speicfy mark as helpful permission rules
 17+ // Gives other extension the last chance to specify mark as helpful permission rules
1818 wfRunHooks( 'onMarkItemAsHelpful', array( $params['mahaction'], $params['type'], $params['item'], $wgUser, &$isAbleToMark ) );
1919
2020 if ( !$isAbleToMark ) {

Status & tagging log