r107069 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107068‎ | r107069 | r107070 >
Date:15:12, 22 December 2011
Author:hashar
Status:reverted
Tags:
Comment:
wrap linecomment js initializer in a ready() block


follow up r95435
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
——@@ -208,7 +208,7 @@
209209 if( $wgCodeReviewInlineComments ) {
210210 $wgOut->addModules( 'ext.codereview.linecomment' );
211211 $wgOut->addInlineScript(
212 - "CodeReview.lcInit( $encRev );"
 212+ "$(document).ready( CodeReview.lcInit( $encRev ) );"
213213 );
214214 }
215215

Follow-up revisions

RevisionCommit summaryAuthorDate
r108350Reverting inline commenting from CodeReview...johnduhart06:55, 8 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95435add inline comments to the diff output...hashar19:53, 24 August 2011

Status & tagging log