r107064 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107063‎ | r107064 | r107065 >
Date:13:18, 22 December 2011
Author:j
Status:resolved
Tags:
Comment:
- add comment to document us_chunk_inx in sql file
- fix chunk upload to work with recent filerepo changes
Follow up r104687
Modified paths:
  • /trunk/phase3/includes/upload/UploadFromChunks.php (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
@@ -966,7 +966,8 @@
967967 us_timestamp varbinary(14) not null,
968968
969969 us_status varchar(50) not null,
970 -
 970+
 971+ -- chunk counter starts at 0, current offset is stored in us_size
971972 us_chunk_inx int unsigned NULL,
972973
973974 -- file properties from File::getPropsFromPath. these may prove unnecessary.
Index: trunk/phase3/includes/upload/UploadFromChunks.php
@@ -56,7 +56,7 @@
5757 $this->mFileKey = $this->mLocalFile->getFileKey();
5858
5959 // Output a copy of this first to chunk 0 location:
60 - $status = $this->outputChunk( $this->mLocalFile->getPath() );
 60+ $status = $this->outputChunk( $this->mLocalFile->getLocalRefPath() );
6161
6262 // Update db table to reflect initial "chunk" state
6363 $this->updateChunkStatus();

Follow-up revisions

RevisionCommit summaryAuthorDate
r107144Use getPath, all operations are on filerepo level no need to get a local path...j09:30, 23 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104687Use database to track uploaded chunks and concatenate at the end....j14:56, 30 November 2011

Status & tagging log