r107053 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107052‎ | r107053 | r107054 >
Date:10:26, 22 December 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Rename sgroup to subgroup for clarity and consistency
Modified paths:
  • /trunk/extensions/Translate/utils/MessageGroupStats.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageGroupStats.php
@@ -230,7 +230,7 @@
231231 $stats = self::extractResults( $res, $stats );
232232
233233 $aggregates = array( 0, 0, 0 );
234 - foreach ( $group->getGroups() as $sid => $sgroup ) {
 234+ foreach ( $group->getGroups() as $sid => $subgroup ) {
235235 # Discouraged groups may belong to a another group, usually if there
236236 # is a aggregate group for all translatable pages. In that case
237237 # calculate and store the statistics, but don't count them as part of
@@ -238,9 +238,9 @@
239239 # add up. The statistics for discouraged groups can still be viewed
240240 # through Special:MessageGroupStats.
241241 if ( !isset( $stats[$sid][$code] ) ) {
242 - $stats[$sid][$code] = self::forItemInternal( $stats, $sgroup, $code );
 242+ $stats[$sid][$code] = self::forItemInternal( $stats, $subgroup, $code );
243243 }
244 - if ( MessageGroups::getPriority( $sgroup ) !== 'discouraged' ) {
 244+ if ( MessageGroups::getPriority( $subgroup ) !== 'discouraged' ) {
245245 $aggregates = self::multiAdd( $aggregates, $stats[$sid][$code] );
246246 }
247247 }

Status & tagging log