r107020 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107019‎ | r107020 | r107021 >
Date:00:43, 22 December 2011
Author:aaron
Status:ok
Tags:
Comment:
FU r105512: urldecode() the file and thumb name in wfExtractThumbParams() for 404 handling as needed.
Modified paths:
  • /trunk/phase3/thumb.php (modified) (history)

Diff [purge]

Index: trunk/phase3/thumb.php
@@ -233,6 +233,8 @@
234234 // Check if this is a valid looking thumbnail request...
235235 if ( preg_match( $thumbUrlRegex, $uri, $matches ) ) {
236236 list( /* all */, $archOrTemp, $filename, $thumbname ) = $matches;
 237+ $filename = urldecode( $filename );
 238+ $thumbname = urldecode( $thumbname );
237239
238240 $params = array( 'f' => $filename );
239241 if ( $archOrTemp == '/archive' ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105512FU r101117: removed cURL thumb handler code and made thumb_handler.php a thin...aaron03:43, 8 December 2011

Status & tagging log