r106960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106959‎ | r106960 | r106961 >
Date:18:40, 21 December 2011
Author:ialex
Status:ok
Tags:
Comment:
Use accessor instead of the member variable directly and factorise the calls to it
Modified paths:
  • /trunk/phase3/includes/specials/SpecialConfirmemail.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialConfirmemail.php
@@ -88,9 +88,10 @@
8989 // $time is kept for backward compat reasons.
9090 // 'emailauthenticated' is also used in SpecialPreferences.php
9191 $lang = $this->getLanguage();
92 - $time = $lang->userTimeAndDate( $user->mEmailAuthenticated, $user );
93 - $d = $lang->userDate( $user->mEmailAuthenticated, $user );
94 - $t = $lang->userTime( $user->mEmailAuthenticated, $user );
 92+ $emailAuthenticated = $user->getEmailAuthenticationTimestamp();
 93+ $time = $lang->userTimeAndDate( $emailAuthenticated, $user );
 94+ $d = $lang->userDate( $emailAuthenticated, $user );
 95+ $t = $lang->userTime( $emailAuthenticated, $user );
9596 $out->addWikiMsg( 'emailauthenticated', $time, $d, $t );
9697 }
9798 if( $user->isEmailConfirmationPending() ) {

Status & tagging log