r106949 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106948‎ | r106949 | r106950 >
Date:15:52, 21 December 2011
Author:j
Status:ok
Tags:
Comment:
use getLocalRefPath to get path of video, an empty file at thumbnail exists now, overwrite it
Modified paths:
  • /trunk/extensions/TimedMediaHandler/TimedMediaThumbnail.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaThumbnail.php
@@ -31,7 +31,8 @@
3232 $cmd .= ' -ss ' . ($offset - 2);
3333 $offset = 2;
3434 }
35 - $cmd .= ' -i ' . wfEscapeShellArg( $options['file']->getPath() );
 35+ $srcPath = $options['file']->getLocalRefPath();
 36+ $cmd .= ' -y -i ' . wfEscapeShellArg( $srcPath );
3637 $cmd .= ' -ss ' . $offset . ' ';
3738
3839 // Set the output size if set in options:

Status & tagging log