r106891 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106890‎ | r106891 | r106892 >
Date:23:23, 20 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix boolean fail due to tiredness from r106721 and r106724
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -506,12 +506,12 @@
507507 $mobileAction = $wgRequest->getText( 'mobileaction' );
508508 $action = $wgRequest->getText( 'action' );
509509
510 - if ( self::$useFormat !== 'mobile' || self::$useFormat !== 'mobile-wap' ||
 510+ if ( self::$useFormat !== 'mobile' && self::$useFormat !== 'mobile-wap' &&
511511 !$xDevice ) {
512512 wfProfileOut( __METHOD__ );
513513 return true;
514514 }
515 - if ( $action === 'edit' &&
 515+ if ( $action === 'edit' ||
516516 $mobileAction === 'view_normal_site' ) {
517517 wfProfileOut( __METHOD__ );
518518 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106721Reducing indenting by one level as it was too much, and another by inverting ...reedy23:27, 19 December 2011
r106724Reduce more indentingreedy23:35, 19 December 2011

Status & tagging log