r106861 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106860‎ | r106861 | r106862 >
Date:21:18, 20 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Swap

require( "$IP/maintenance/Maintenance.php" );

for

require_once( "$IP/maintenance/Maintenance.php" );

Saves daft errors if you have multiple things including it
Modified paths:
  • /trunk/extensions/AntiSpoof/maintenance/batchAntiSpoof.php (modified) (history)
  • /trunk/extensions/AntiSpoof/maintenance/generateEquivset.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/populateAFRevisions.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/populateAFStatistics.php (modified) (history)
  • /trunk/extensions/CentralAuth/AntiSpoof/batchCAAntiSpoof.php (modified) (history)
  • /trunk/extensions/CentralAuth/CentralAuthPlugin.php (modified) (history)
  • /trunk/extensions/CodeReview/maintenance/bulkStatusUpdate.php (modified) (history)
  • /trunk/extensions/CodeReview/maintenance/populateFollowupRevisions.php (modified) (history)
  • /trunk/extensions/CodeReview/maintenance/repopulateCodePaths.php (modified) (history)
  • /trunk/extensions/CodeReview/maintenance/showEmails.php (modified) (history)
  • /trunk/extensions/CodeReview/maintenance/svnImport.php (modified) (history)
  • /trunk/extensions/ContributionReporting/PopulateFundraisingStatistics.php (modified) (history)
  • /trunk/extensions/DontSwitchMeOver/maintenence/post-switchover.php (modified) (history)
  • /trunk/extensions/MetricsReporting/MetricsMaintenance.php (modified) (history)
  • /trunk/extensions/MoodBar/exportMoodBar.php (modified) (history)
  • /trunk/extensions/OpenID/optionToTable.php (modified) (history)
  • /trunk/extensions/Renameuser/renameUserCleanup.php (modified) (history)
  • /trunk/extensions/ShortUrl/populateShortUrlTable.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/maintenance/WebVideoJobRunner.php (modified) (history)
  • /trunk/extensions/WikimediaMaintenance/WikimediaMaintenance.php (modified) (history)
  • /trunk/extensions/WikimediaMaintenance/cleanupBug31576.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DontSwitchMeOver/maintenence/post-switchover.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class PostSwitchover extends Maintenance {
1111 const REPORTING_INTERVAL = 1000;
Index: trunk/extensions/ArticleFeedback/populateAFStatistics.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class PopulateAFStatistics extends Maintenance {
1111 /**
Index: trunk/extensions/ArticleFeedback/populateAFRevisions.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class PopulateAFRevisions extends Maintenance {
1111 const REPORTING_INTERVAL = 100;
——@@ -141,4 +141,4 @@
142142 }
143143
144144 $maintClass = "PopulateAFRevisions";
145 -require_once( DO_MAINTENANCE );
\ No newline at end of file
 145+require_once( DO_MAINTENANCE );
Index: trunk/extensions/MetricsReporting/MetricsMaintenance.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 abstract class MetricsMaintenance extends Maintenance {
1111 private $db;
Index: trunk/extensions/ContributionReporting/PopulateFundraisingStatistics.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class PopulateFundraisingStatistics extends Maintenance {
1111 /**
Index: trunk/extensions/CentralAuth/CentralAuthPlugin.php
——@@ -249,5 +249,4 @@
250250 public function getUserInstance( User &$user ) {
251251 return CentralAuthUser::getInstance( $user );
252252 }
253 -
254253 }
Index: trunk/extensions/CentralAuth/AntiSpoof/batchCAAntiSpoof.php
——@@ -5,7 +5,7 @@
66 if ( $IP === false ) {
77 $IP = dirname( __FILE__ ) . '/../../..';
88 }
9 -require( "$IP/maintenance/Maintenance.php" );
 9+require_once( "$IP/maintenance/Maintenance.php" );
1010
1111 class BatchCAAntiSpoof extends BatchAntiSpoof {
1212
Index: trunk/extensions/TimedMediaHandler/maintenance/WebVideoJobRunner.php
——@@ -9,7 +9,7 @@
1010 if ( $IP === false ) {
1111 $IP = dirname( __FILE__ ) . '/../../..';
1212 }
13 -require( "$IP/maintenance/Maintenance.php" );
 13+require_once( "$IP/maintenance/Maintenance.php" );
1414
1515 class WebVideoJobRunner extends Maintenance {
1616 // Default number of simultaneous transcoding threads
Index: trunk/extensions/OpenID/optionToTable.php
——@@ -27,7 +27,7 @@
2828 if ( $IP === false ) {
2929 $IP = dirname( __FILE__ ) . '/../..';
3030 }
31 -require( "$IP/maintenance/Maintenance.php" );
 31+require_once( "$IP/maintenance/Maintenance.php" );
3232
3333 class OpenIDOptionToTable extends Maintenance {
3434 public function __construct() {
Index: trunk/extensions/Renameuser/renameUserCleanup.php
——@@ -27,7 +27,7 @@
2828 if ( $IP === false ) {
2929 $IP = dirname( __FILE__ ) . '/../..';
3030 }
31 -require( "$IP/maintenance/Maintenance.php" );
 31+require_once( "$IP/maintenance/Maintenance.php" );
3232
3333 class RenameUserCleanup extends Maintenance {
3434 public function __construct() {
Index: trunk/extensions/CodeReview/maintenance/repopulateCodePaths.php
——@@ -3,7 +3,7 @@
44 if ( $IP === false ) {
55 $IP = dirname( __FILE__ ) . '/../..';
66 }
7 -require( "$IP/maintenance/Maintenance.php" );
 7+require_once( "$IP/maintenance/Maintenance.php" );
88
99 class RepopulateCodePaths extends Maintenance {
1010 public function __construct() {
Index: trunk/extensions/CodeReview/maintenance/showEmails.php
——@@ -4,7 +4,7 @@
55 if( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class CodeReviewShowEmails extends Maintenance {
1111 private $EmailData = array(
Index: trunk/extensions/CodeReview/maintenance/svnImport.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class SvnImport extends Maintenance {
1111
Index: trunk/extensions/CodeReview/maintenance/populateFollowupRevisions.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class PopulateFollowupRevisions extends Maintenance {
1111 public function __construct() {
——@@ -68,4 +68,4 @@
6969 }
7070
7171 $maintClass = "PopulateFollowupRevisions";
72 -require_once( DO_MAINTENANCE );
\ No newline at end of file
 72+require_once( DO_MAINTENANCE );
Index: trunk/extensions/CodeReview/maintenance/bulkStatusUpdate.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class BulkStatusUpdate extends Maintenance {
1111
Index: trunk/extensions/AntiSpoof/maintenance/generateEquivset.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class GenerateEquivset extends Maintenance {
1111 public function execute() {
Index: trunk/extensions/AntiSpoof/maintenance/batchAntiSpoof.php
——@@ -5,7 +5,7 @@
66 if ( $IP === false ) {
77 $IP = dirname( __FILE__ ) . '/../../..';
88 }
9 -require( "$IP/maintenance/Maintenance.php" );
 9+require_once( "$IP/maintenance/Maintenance.php" );
1010
1111 class BatchAntiSpoof extends Maintenance {
1212
Index: trunk/extensions/WikimediaMaintenance/cleanupBug31576.php
——@@ -3,7 +3,7 @@
44 if ( $IP === false ) {
55 $IP = dirname( __FILE__ ) . '/../..';
66 }
7 -require( "$IP/maintenance/Maintenance.php" );
 7+require_once( "$IP/maintenance/Maintenance.php" );
88
99 class CleanupBug31576 extends Maintenance {
1010 public function __construct() {
——@@ -61,4 +61,4 @@
6262 }
6363
6464 $maintClass = "CleanupBug31576";
65 -require_once( RUN_MAINTENANCE_IF_MAIN );
\ No newline at end of file
 65+require_once( RUN_MAINTENANCE_IF_MAIN );
Index: trunk/extensions/WikimediaMaintenance/WikimediaMaintenance.php
——@@ -10,7 +10,7 @@
1111 }
1212
1313 // Require base maintenance class
14 -require( "$IP/maintenance/Maintenance.php" );
 14+require_once( "$IP/maintenance/Maintenance.php" );
1515
1616 // Some scripts need the WMFSite class, so include that too
1717 require( dirname( __FILE__ ) . '/WMFSite.php' );
Index: trunk/extensions/ShortUrl/populateShortUrlTable.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class PopulateShortUrlsTable extends Maintenance {
1111 public function __construct() {
Index: trunk/extensions/MoodBar/exportMoodBar.php
——@@ -4,7 +4,7 @@
55 if ( $IP === false ) {
66 $IP = dirname( __FILE__ ) . '/../..';
77 }
8 -require( "$IP/maintenance/Maintenance.php" );
 8+require_once( "$IP/maintenance/Maintenance.php" );
99
1010 class ExportMoodBar extends Maintenance {
1111 protected $fields = array(

Status & tagging log