r106850 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106849‎ | r106850 | r106851 >
Date:20:15, 20 December 2011
Author:aaron
Status:ok
Tags:
Comment:
FU r106770: fixed the other getTransform() call
Modified paths:
  • /trunk/phase3/includes/filerepo/file/File.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/file/File.php
@@ -769,7 +769,10 @@
770770 if ( $this->repo->fileExists( $thumbPath ) && !( $flags & self::RENDER_FORCE ) ) {
771771 $timestamp = $this->repo->getFileTimestamp( $thumbPath );
772772 if ( $timestamp !== false && $timestamp >= $wgThumbnailEpoch ) {
773 - return $this->handler->getTransform( $this, false, $thumbUrl, $params );
 773+ // XXX: Pass in the storage path even though we are not rendering anything
 774+ // and the path is supposed to be an FS path. This is due to getScalerType()
 775+ // getting called on the path and clobbering $thumb->getUrl() if it's false.
 776+ return $this->handler->getTransform( $this, $thumbPath, $thumbUrl, $params );
774777 }
775778 } elseif ( $flags & self::RENDER_FORCE ) {
776779 wfDebug( __METHOD__ . " forcing rendering per flag File::RENDER_FORCE\n" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106770FU r106752: unbreak "other sizes" links on File: pages by working around the ...aaron08:38, 20 December 2011

Status & tagging log