r106840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106839‎ | r106840 | r106841 >
Date:19:24, 20 December 2011
Author:reedy
Status:ok
Tags:
Comment:
MFT r106839

Be gone vile checkbox! Be gone!
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CentralAuth (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuth.i18n.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthHooks.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthPlugin.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthPlugin.php
@@ -251,21 +251,5 @@
252252 public function getUserInstance( User &$user ) {
253253 return CentralAuthUser::getInstance( $user );
254254 }
255 -
256 - public function modifyUITemplate( &$template, &$type ) {
257 - global $wgCentralAuthCookies;
258255
259 - $template->set( 'usedomain', false );
260 -
261 - if ( !$wgCentralAuthCookies ) return;
262 -
263 - $label = Xml::checkLabel( wfMsg( 'centralauth-login-global' ), 'wpCentralLogin', 'wpCentralLogin', true, array( 'tabindex' => '4' ) );
264 - $field = <<<HTML
265 - <tr id="mw-centralauth-login">
266 - <td></td>
267 - <td class="mw-input">$label</td>
268 - </tr>
269 -HTML;
270 - $template->set( 'extrafields', $field );
271 - }
272256 }
Index: branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthHooks.php
@@ -125,7 +125,7 @@
126126 }
127127
128128 static function onUserLoginComplete( &$user, &$inject_html ) {
129 - global $wgCentralAuthCookies, $wgRequest;
 129+ global $wgCentralAuthCookies;
130130 if ( !$wgCentralAuthCookies ) {
131131 // Use local sessions only.
132132 return true;
@@ -144,11 +144,6 @@
145145 return true;
146146 }
147147
148 - if ( !$wgRequest->getCheck( 'wpCentralLogin' ) ) {
149 - // The user requested to log in just on this wiki
150 - return true;
151 - }
152 -
153148 $inject_html .= '<div class="centralauth-login-box"><p>' .
154149 wfMsgExt( 'centralauth-login-progress', array( 'parsemag' ), $user->getName() ) . "</p>\n<p>";
155150 foreach ( $wgCentralAuthAutoLoginWikis as $alt => $wiki ) {
Index: branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuth.i18n.php
@@ -35,7 +35,6 @@
3636 'centralauth-merge-step2-detail' => "Some of the accounts could not be automatically matched to the designated home wiki.
3737 If these accounts belong to you, you can confirm that they are yours by providing the password for them.",
3838 'centralauth-merge-step2-submit' => 'Confirm login information',
39 - 'centralauth-login-global' => 'Also log me in to other wikis of {{int:Centralauth-groupname}}',
4039
4140 // Dry run messages
4241 'centralauth-merge-dryrun-complete' => 'All existing accounts can be automatically unified!
Property changes on: branches/wmf/1.18wmf1/extensions/CentralAuth
___________________________________________________________________
Modified: svn:mergeinfo
4342 Merged /trunk/extensions/CentralAuth:r106839

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106839Revert r75041: adds extra "do what you should always do 100% of the time" che...brion19:19, 20 December 2011

Status & tagging log