r106812 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106811‎ | r106812 | r106813 >
Date:16:51, 20 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r106809, don't use class_exists, use MWInit::classExists() (I think we need to, right?

Expand comment
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuth.php
@@ -264,7 +264,9 @@
265265 ) + $commonModuleInfo;
266266
267267 // If AntiSpoof is installed, we can do some AntiSpoof stuff for CA
268 -if ( class_exists( 'AntiSpoof' ) ) {
 268+// Though, doing it this way, AntiSpoof has to be loaded/included first
 269+// I guess this is bug 30234
 270+if ( MWInit::classExists( 'AntiSpoof' ) ) {
269271 $wgAutoloadClasses['CentralAuthSpoofUser'] = "$caBase/AntiSpoof/CentralAuthSpoofUser.php";
270272 $wgAutoloadClasses['CentralAuthAntiSpoofHooks'] = "$caBase/AntiSpoof/CentralAuthAntiSpoofHooks.php";
271273

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106809Followup r106808...reedy16:29, 20 December 2011

Status & tagging log