r106785 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106784‎ | r106785 | r106786 >
Date:12:33, 20 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove # from r106784 and fix @throws to list the correct exception which could be thrown
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthReadOnlyError.php (modified) (history)
  • /trunk/extensions/CentralAuth/CentralAuthUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthUser.php
@@ -71,7 +71,7 @@
7272 * Gets a master (read/write) database connection to the CentralAuth database
7373 *
7474 * @return DatabaseBase
75 - * @throws ReadOnlyError
 75+ * @throws CentralAuthReadOnlyError
7676 */
7777 public static function getCentralDB() {
7878 global $wgCentralAuthDatabase, $wgCentralAuthReadOnly;
@@ -84,7 +84,7 @@
8585
8686 /**
8787 * Gets a slave (readonly) database connection to the CentralAuth database
88 - *
 88+ *
8989 * @return DatabaseBase
9090 */
9191 public static function getCentralSlaveDB() {
Index: trunk/extensions/CentralAuth/CentralAuthReadOnlyError.php
@@ -2,7 +2,7 @@
33
44 /**
55 * Show an error when the CentralAuth database is locked/read-only
6 - * and the user tries to do something that requires CentralAuth#
 6+ * and the user tries to do something that requires CentralAuth
77 * write access
88 * @ingroup Exception
99 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106784* (bug 31170) centralauth needs a read-only db flag that allows queries to go...reedy12:24, 20 December 2011

Status & tagging log