r106736 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106735‎ | r106736 | r106737 >
Date:00:14, 20 December 2011
Author:raindrift
Status:ok
Tags:
Comment:
jslint pass (vars still redeclared, but fixed the browser-breaking stuff)
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/TimedText/resources/mw.TimedText.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/TimedText/resources/mw.TimedText.js
@@ -116,7 +116,7 @@
117117 },
118118 destroy:function(){
119119 // remove any old player bindings;
120 - $( this.embedPlayer ).unbind( this.bindPostFix )
 120+ $( this.embedPlayer ).unbind( this.bindPostFix );
121121 },
122122 /**
123123 * Add timed text related player bindings
@@ -346,7 +346,7 @@
347347
348348 var positionOpts = { };
349349 if( this.embedPlayer.supports[ 'overlays' ] ){
350 - var positionOpts = {
 350+ positionOpts = {
351351 'directionV' : 'up',
352352 'offsetY' : this.embedPlayer.controlBuilder.getHeight(),
353353 'directionH' : 'left',
@@ -963,8 +963,8 @@
964964 if( $capTarget.length == 0 ){
965965 $capTarget = $( '<div />' )
966966 .addClass( 'captionsLayoutTarget' )
967 - .css( layoutCss )
968 - this.embedPlayer.$interface.append( $capTarget )
 967+ .css( layoutCss );
 968+ this.embedPlayer.$interface.append( $capTarget );
969969 }
970970 return $capTarget;
971971 },
@@ -1035,7 +1035,7 @@
10361036 'bottom': 10,
10371037 'width': '100%',
10381038 'display': 'block',
1039 - 'opacity': .8,
 1039+ 'opacity': 0.8,
10401040 'text-align': 'center',
10411041 'z-index': 2
10421042 };
@@ -1103,7 +1103,7 @@
11041104 }
11051105 if( options.fontsize ) {
11061106 // Translate to em size so that font-size parent percentage
1107 - style[ "font-size" ] = ( options.fontsize > 24 ) ? '1.5em' : Math.round( options.fontsize * .0625 * 1000 ) / 1000 + 'em';
 1107+ style[ "font-size" ] = ( options.fontsize > 24 ) ? '1.5em' : Math.round( options.fontsize * 0.0625 * 1000 ) / 1000 + 'em';
11081108 }
11091109
11101110 if( options.useGlow && options.glowBlur && options.glowColor ) {

Status & tagging log