r106674 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106673‎ | r106674 | r106675 >
Date:19:13, 19 December 2011
Author:aaron
Status:deferred
Tags:
Comment:
* Fixed ConcatenateFileOp::allowedParams()
* testConcatenate() cleanups
Modified paths:
  • /branches/FileBackend/phase3/includes/filerepo/backend/FileOp.php (modified) (history)
  • /branches/FileBackend/phase3/tests/phpunit/includes/filerepo/FileBackendTest.php (modified) (history)

Diff [purge]

Index: branches/FileBackend/phase3/tests/phpunit/includes/filerepo/FileBackendTest.php
@@ -343,11 +343,11 @@
344344 );
345345 $expContent .= $srcsContent[$i];
346346 }
347 - $dest = $op['dst'];
348347 $status = $this->backend->doOperations( $ops );
349348
350 - $this->assertEquals( true, $status->isOK(), "Creation of concat file at $dest succeeded." );
 349+ $this->assertEquals( true, $status->isOK(), "Creation of source files succeeded." );
351350
 351+ $dest = $op['dst'];
352352 if ( $alreadyExists ) {
353353 $oldText = 'blah...blah...waahwaah';
354354 $status = $this->backend->doOperation(
Index: branches/FileBackend/phase3/includes/filerepo/backend/FileOp.php
@@ -811,7 +811,7 @@
812812 */
813813 class ConcatenateFileOp extends FileOp {
814814 protected function allowedParams() {
815 - return array( 'src', 'dst', 'overwriteDest' );
 815+ return array( 'srcs', 'dst', 'overwriteDest' );
816816 }
817817
818818 protected function doPrecheck( array &$predicates ) {

Status & tagging log