r106647 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106646‎ | r106647 | r106648 >
Date:13:27, 19 December 2011
Author:catrope
Status:ok
Tags:
Comment:
[RL2] Make GadgetResourceLoaderModule::getPages() public for testability
Modified paths:
  • /branches/RL2/extensions/Gadgets/backend/GadgetResourceLoaderModule.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/backend/GadgetResourceLoaderModule.php
@@ -33,10 +33,12 @@
3434 }
3535
3636 /**
37 - * Overrides the abstract function from ResourceLoaderWikiModule class
 37+ * Overrides the abstract function from ResourceLoaderWikiModule class.
 38+ *
 39+ * This method is public because it's used by GadgetTest.php
3840 * @return Array: $pages passed to __construct()
3941 */
40 - protected function getPages( ResourceLoaderContext $context ) {
 42+ public function getPages( ResourceLoaderContext $context ) {
4143 return $this->pages;
4244 }
4345

Status & tagging log