r106644 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106643‎ | r106644 | r106645 >
Date:11:43, 19 December 2011
Author:raymond
Status:ok
Tags:
Comment:
r105915: Some consistency tweaks:
* No need to construct longer messages. Just use a string
* Extend extension credits, still some keys commented out
Before the extension can be added to translatewiki.net pls add message documention, see https://www.mediawiki.org/wiki/I18n#Message_documentation
Modified paths:
  • /trunk/extensions/UploadLocal/UploadLocal.i18n.php (modified) (history)
  • /trunk/extensions/UploadLocal/UploadLocal.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadLocal/UploadLocal.i18n.php
@@ -8,50 +8,43 @@
99 $messages = array();
1010
1111 $messages['en'] = array(
12 - 'specialuploadlocal' => 'Upload Local Files',
 12+ 'uploadlocal-desc' => 'Allows users to link in files already on the server'
 13+ 'specialuploadlocal' => 'Upload local files',
1314 'uploadlocal' => 'Upload local files',
14 - 'uploadlocal_directory_readonly' => 'The local upload directory ($1) is'.
15 - ' not writeable by the webserver.',
16 - 'uploadlocaltext' => 'Use this form to mass upload files already on the'.
17 - ' server in the upload local directory. You can find out more'.
18 - ' general information at [[Special:Upload|the regular upload file'.
19 - ' page]].',
 15+ 'uploadlocal_directory_readonly' => 'The local upload directory ($1) is not writeable by the webserver.',
 16+ 'uploadlocaltext' => 'Use this form to mass upload files already on the server in the upload local directory.
 17+You can find out more general information at [[Special:Upload|the regular upload file page]].',
2018 'uploadlocalbtn' => 'Upload local files',
21 - 'nolocalfiles' => 'There are no files in the local upload folder. Try'.
22 - ' placing some files in "<code>$1</code>."',
 19+ 'nolocalfiles' => 'There are no files in the local upload folder. Try placing some files in "<code>$1</code>."',
2320 'uploadednolocalfiles' => 'You did not upload any files.',
2421 'allfilessuccessful' => 'All files uploaded successfully',
2522 'uploadlocalerrors' => 'Some files had errors',
26 - 'allfilessuccessfultext' => 'All files uploaded successfully. Return to'.
27 - ' [[Main Page]].',
28 - 'uploadlocal_descriptions_append' => 'Append to description: ',
29 - 'uploadlocal_descriptions_prepend' => 'Prepend to description: ',
30 - 'uploadlocal_dest_file_append' => 'Append to dest. filename: ',
31 - 'uploadlocal_dest_file_prepend' => 'Prepend to dest. filename: ',
 23+ 'allfilessuccessfultext' => 'All files uploaded successfully.
 24+Return to [[{{int:mainpage}}]].',
 25+ 'uploadlocal_descriptions_append' => 'Append to description:',
 26+ 'uploadlocal_descriptions_prepend' => 'Prepend to description:',
 27+ 'uploadlocal_dest_file_append' => 'Append to destination filename:',
 28+ 'uploadlocal_dest_file_prepend' => 'Prepend to destination filename: ',
3229 'uploadlocal_file_list' => 'Files ready for upload',
33 - 'uploadlocal_file_list_explanation' => '\'\'\'X\'\'\' indicates'.
34 - ' whether or not you want the file to be uploaded (uncheck to'.
35 - ' prevent a file from being processed). \'\'\'W\'\'\' indicates'.
36 - ' whether you want the file added to your watchlist.',
 30+ 'uploadlocal_file_list_explanation' => "'''X''' indicates whether or not you want the file to be uploaded (uncheck to prevent a file from being processed).
 31+'''W''' indicates whether you want the file added to your watchlist.",
3732 'uploadlocal_global_params' => 'Global parameters',
38 - 'uploadlocal_global_params_explanation' => 'What is entered here will'.
39 - ' automatically get added to the entries listed above. This helps'.
40 - ' remove repetitive text such as categories and metadata. To \'\'\''.
41 - 'append\'\'\' is to add to the end of text, while to \'\'\'prepend'.
42 - '\'\'\' means to add to the beginning of text. Especially for'.
43 - ' descriptions, make sure you give a few linebreaks before/after'.
44 - ' the text.',
 33+ 'uploadlocal_global_params_explanation' => "What is entered here will automatically get added to the entries listed above.
 34+This helps remove repetitive text such as categories and metadata.
 35+To '''append''' is to add to the end of text, while to '''prepend''' means to add to the beginning of text.
 36+Especially for descriptions, make sure you give a few linebreaks before/after the text.",
4537
46 - 'uploadlocal_error_exists' => 'The file $1 already exists',
47 - 'uploadlocal_error_empty' => 'The file you submitted was empty',
48 - 'uploadlocal_error_missing' => 'The file is missing an extension',
49 - 'uploadlocal_error_badtype' => 'This type of file is banned',
50 - 'uploadlocal_error_tooshort' => 'The filename is too short',
51 - 'uploadlocal_error_illegal' => 'The filename is not allowed',
52 - 'uploadlocal_error_overwrite' => 'Overwriting an existing file is not allowed',
53 - 'uploadlocal_error_verify' => 'This file did not pass file verification: $1',
54 - 'uploadlocal_error_hook' => 'The modification you tried to make was aborted by an extension hook',
55 - 'uploadlocal_error_unknown' => 'An unknown error occurred',
 38+ 'uploadlocal_error_exists' => 'The file $1 already exists.',
 39+ 'uploadlocal_error_empty' => 'The file you submitted was empty.',
 40+ 'uploadlocal_error_missing' => 'The file is missing an extension.',
 41+ 'uploadlocal_error_badtype' => 'This type of file is banned.',
 42+ 'uploadlocal_error_tooshort' => 'The filename is too short.',
 43+ 'uploadlocal_error_illegal' => 'The filename is not allowed.',
 44+ 'uploadlocal_error_overwrite' => 'Overwriting an existing file is not allowed.',
 45+ 'uploadlocal_error_verify' => 'This file did not pass file verification: $1.',
 46+ 'uploadlocal_error_hook' => 'The modification you tried to make was aborted by an extension hook.',
 47+ 'uploadlocal_error_unknown' => 'An unknown error occurred.',
5648
5749 'right-uploadlocal' => 'Upload files from the local machine'
5850 );
 51+
Index: trunk/extensions/UploadLocal/UploadLocal.php
@@ -20,8 +20,12 @@
2121 */
2222
2323 $wgExtensionCredits['specialpage'][] = array(
 24+ 'path' => __FILE__,
2425 'name' => 'UploadLocal',
25 - 'description' => 'allows users to link in files already on the server'
 26+ 'descriptionmsg' => 'uploadlocal-desc',
 27+ //'author' => array( '' ),
 28+ // 'version' => '',
 29+ // 'url' => 'https://www.mediawiki.org/wiki/Extension:UploadLocal'
2630 );
2731 $wgSpecialPages['UploadLocal'] = 'UploadLocal';
2832 $wgExtensionMessagesFiles['UploadLocal'] = dirname( __FILE__ ) . '/UploadLocal.i18n.php';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105915Rename to UploadLocal.cneubauer18:59, 12 December 2011

Status & tagging log