r106626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106625‎ | r106626 | r106627 >
Date:06:02, 19 December 2011
Author:aaron
Status:deferred
Tags:
Comment:
* Simple fix to CreateFileOp::allowedParams()
* Comment tweaks
Modified paths:
  • /branches/FileBackend/phase3/includes/filerepo/backend/FileOp.php (modified) (history)
  • /branches/FileBackend/phase3/maintenance/locking/LockServerDaemon.php (modified) (history)

Diff [purge]

Index: branches/FileBackend/phase3/maintenance/locking/LockServerDaemon.php
@@ -159,7 +159,7 @@
160160 $data = @socket_read( $read_sock, 65535, PHP_NORMAL_READ );
161161 // Check if the client is disconnected
162162 if ( $data === false ) {
163 - // Remove client for $clients array
 163+ // Remove client from $clients list
164164 $key = array_search( $read_sock, $clients );
165165 unset( $clients[$key] );
166166 // Remove socket's session from tracking (if it exists)
Index: branches/FileBackend/phase3/includes/filerepo/backend/FileOp.php
@@ -579,7 +579,7 @@
580580 */
581581 class CreateFileOp extends FileOp {
582582 protected function allowedParams() {
583 - return array( 'src', 'dst', 'overwriteDest', 'overwriteSame' );
 583+ return array( 'content', 'dst', 'overwriteDest', 'overwriteSame' );
584584 }
585585
586586 protected function doPrecheck( array &$predicates ) {

Status & tagging log