r106592 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106591‎ | r106592 | r106593 >
Date:19:47, 18 December 2011
Author:raymond
Status:resolved
Tags:
Comment:
r106260: Consistency tweaks in preparation for adding extension to translatewiki.net:
Prefix message key with the extension name to avoid key conflicts with core and/or other extensions
Modified paths:
  • /trunk/extensions/SoundManager2Button/SoundManager2Button.i18n.php (modified) (history)
  • /trunk/extensions/SoundManager2Button/SoundManager2Button.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SoundManager2Button/SoundManager2Button.i18n.php
@@ -11,11 +11,12 @@
1212
1313 $messages['en'] = array(
1414 'soundmanager2button-desc' => 'Embeds a SoundManager 2 MP3 player into a wiki page',
15 - 'play' => 'Play.',
 15+ 'play' => 'Play',
1616 );
1717
1818 # Message documentation (Message documentation)
1919 $messages['qqq'] = array(
2020 'soundmanager2button-desc' => '{{desc}}',
21 - 'play' => 'Play button text, primarily for screenreaders.',
 21+ 'soundmanager2button-play' => 'Play button text, primarily for screenreaders.',
2222 );
 23+
Index: trunk/extensions/SoundManager2Button/SoundManager2Button.php
@@ -99,7 +99,7 @@
100100 $output = '';
101101 if( $file ) {
102102 $url = $file->getFullURL();
103 - $output='<a href="'.$url.'" title="'.wfMsgForContent('play').'" class="sm2_button">'.wfMsgForContent('play').'</a>';
 103+ $output='<a href="'.$url.'" title="'.wfMsgForContent('soundmanager2button-play').'" class="sm2_button">'.wfMsgForContent('soundmanager2button-play').'</a>';
104104 }
105105
106106 return $output;

Follow-up revisions

RevisionCommit summaryAuthorDate
r106593r106260: Consistency tweaks in preparation for adding extension to translatew...raymond19:48, 18 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106260Import SoundManager2Button extension.kroocsiogsi22:17, 14 December 2011

Status & tagging log