r106569 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106568‎ | r106569 | r106570 >
Date:16:25, 18 December 2011
Author:robin
Status:ok
Tags:
Comment:
Remove ltr class (see r89466), it should not be used at all, because 1) the name is too general, 2) it is automatically added to the body element (colliding class names) and 3) it is better to use HTML dir="ltr" as in r105929.
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -956,13 +956,6 @@
957957 background-position: 0% 100%;
958958 }
959959
960 -/* LTR content in RTL layout */
961 -.ltr {
962 - /* @noflip */
963 - direction: ltr;
964 - unicode-bidi: embed;
965 -}
966 -
967960 #mw-clearyourcache,
968961 #mw-sitecsspreview,
969962 #mw-sitejspreview,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89466Follow up to r89419:...huji14:33, 4 June 2011
r105929No need to use class="ltr", dir="ltr" is betterrobin21:08, 12 December 2011

Status & tagging log