r106544 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106543‎ | r106544 | r106545 >
Date:01:32, 18 December 2011
Author:mah
Status:ok
Tags:
Comment:
w/s
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -163,14 +163,14 @@
164164 // We will check again in Article::view().
165165 $permErrors = $title->getUserPermissionsErrors( 'read', $user );
166166 if ( count( $permErrors ) ) {
167 - // Bug 32276: allowing the skin to generate output with $wgTitle or
168 - // $this->context->title set to the input title would allow anonymous users to
169 - // determine whether a page exists, potentially leaking private data. In fact, the
170 - // curid and oldid request parameters would allow page titles to be enumerated even
171 - // when they are not guessable. So we reset the title to Special:Badtitle before the
 167+ // Bug 32276: allowing the skin to generate output with $wgTitle or
 168+ // $this->context->title set to the input title would allow anonymous users to
 169+ // determine whether a page exists, potentially leaking private data. In fact, the
 170+ // curid and oldid request parameters would allow page titles to be enumerated even
 171+ // when they are not guessable. So we reset the title to Special:Badtitle before the
172172 // permissions error is displayed.
173173 //
174 - // The skin mostly uses $this->context->getTitle() these days, but some extensions
 174+ // The skin mostly uses $this->context->getTitle() these days, but some extensions
175175 // still use $wgTitle.
176176
177177 $badTitle = SpecialPage::getTitleFor( 'Badtitle' );

Status & tagging log