r106533 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106532‎ | r106533 | r106534 >
Date:23:14, 17 December 2011
Author:aaron
Status:ok
Tags:
Comment:
Kill some useless code in r106514
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -414,11 +414,7 @@
415415 }
416416
417417 if ( $this->fld_sha1 ) {
418 - if ( !is_null( $revision->getSha1() ) ) {
419 - $vals['sha1'] = $revision->getSha1();
420 - } else {
421 - $vals['sha1'] = '';
422 - }
 418+ $vals['sha1'] = $revision->getSha1();
423419 }
424420
425421 if ( $this->fld_comment || $this->fld_parsedcomment ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106514Expose rev_sha1/ar_sha1 to API (bug 21860)aaron18:27, 17 December 2011

Status & tagging log