r106471 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106470‎ | r106471 | r106472 >
Date:19:59, 16 December 2011
Author:rsterbin
Status:ok
Tags:
Comment:
Missed an underscore for the learn more url link click tracking id in r106469
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -1970,7 +1970,7 @@
19711971 // Fill in the button link
19721972 var learn_url = mw.msg( 'articlefeedbackv5-cta1-learn-how-url' );
19731973 var learn_track_id = $.articleFeedbackv5.bucketName() + '-' +
1974 - $.articleFeedbackv5.ctaName() + '-button-click-' +
 1974+ $.articleFeedbackv5.ctaName() + '-button_click-' +
19751975 ( $.articleFeedbackv5.inDialog ? 'overlay': 'bottom' );
19761976 $block.find( '.articleFeedbackv5-cta-button' )
19771977 .attr( 'href', $.articleFeedbackv5.trackingUrl( learn_url, learn_track_id ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106469Added edit tracking and tweaked tracking ids for bug #32992:...rsterbin19:40, 16 December 2011

Status & tagging log