r106468 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106467‎ | r106468 | r106469 >
Date:19:36, 16 December 2011
Author:gwicke
Status:deferred
Tags:
Comment:
Fix ranges for annotations in implicit paragraphs within branch nodes.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/parser/mediawiki.DOMConverter.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/parser/mediawiki.DOMConverter.js
@@ -215,8 +215,7 @@
216216 if ( !parNode ) {
217217 newPara();
218218 }
219 - offset = 0;
220 - res = this._convertHTMLAnnotation( cnode, 0, annotationtype );
 219+ res = this._convertHTMLAnnotation( cnode, offset, annotationtype );
221220 //console.log( 'res leaf: ' + JSON.stringify(res, null, 2));
222221 offset += res.text.length;
223222 parNode.content.text += res.text;

Status & tagging log