r106448 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106447‎ | r106448 | r106449 >
Date:17:42, 16 December 2011
Author:rsterbin
Status:ok
Tags:
Comment:
Error messages now match; fixes r106018
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php
@@ -457,7 +457,7 @@
458458 # make sure we have a page/user
459459 if ( !$params['pageid'] || !$wgUser) {
460460 if ( !$feedbackId ) {
461 - $this->dieUsage( 'Saving feedback requires a page ID', 'invalidpageid' );
 461+ $this->dieUsage( 'Page ID is missing or invalid', 'invalidpageid' );
462462 }
463463 }
464464
@@ -465,7 +465,7 @@
466466 if ( !$revId ) {
467467 $title = Title::newFromID( $params['pageid'] );
468468 if ( !$title ) {
469 - $this->dieUsage( 'Page ID is invalid', 'invalidpageid' );
 469+ $this->dieUsage( 'Page ID is missing or invalid', 'invalidpageid' );
470470 }
471471 $revId = $title->getLatestRevID();
472472 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106018Fix for r105252: Not checking the result of Title::newFromID could cause a fa...rsterbin13:06, 13 December 2011

Status & tagging log