r106446 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106445‎ | r106446 | r106447 >
Date:17:19, 16 December 2011
Author:mah
Status:reverted
Tags:
Comment:
followup r103467 - Make sure we pass a user object when we call LoginAuthenticateAudit with self::ILLEGAL
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -524,7 +524,11 @@
525525 # TODO: Allow some magic here for invalid external names, e.g., let the
526526 # user choose a different wiki name.
527527 $u = User::newFromName( $this->mUsername );
528 - if( !( $u instanceof User ) || !User::isUsableName( $u->getName() ) ) {
 528+ if( !( $u instanceof User ) ) {
 529+ wfRunHooks( 'LoginAuthenticateAudit', array( new User, $this->mPassword, self::ILLEGAL ) );
 530+ return self::ILLEGAL;
 531+ }
 532+ if( !User::isUsableName( $u->getName() ) ) {
529533 wfRunHooks( 'LoginAuthenticateAudit', array( $u, $this->mPassword, self::ILLEGAL ) );
530534 return self::ILLEGAL;
531535 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r110797Revert r103467, r106446 (bug 24464: calling LoginAuthenticateAudit hook more ...demon22:44, 6 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103467Adapt and re-apply Michael Newton's patch from Bug 24464 - Execute...mah15:16, 17 November 2011

Status & tagging log