r106428 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106427‎ | r106428 | r106429 >
Date:13:40, 16 December 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 33187) Make af_user_ip nullable
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/alter.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql
@@ -19,7 +19,7 @@
2020 af_page_id integer unsigned NOT NULL,
2121 -- User Id (0 if anon), and ip address
2222 af_user_id integer NOT NULL,
23 - af_user_ip varchar(32) NOT NULL,
 23+ af_user_ip varchar(32) NULL,
2424 -- Unique token for anonymous users (to facilitate ratings from multiple users on the same IP)
2525 af_user_anon_token varbinary(32) NOT NULL DEFAULT '',
2626 -- Foreign key to revision.rev_id
Index: trunk/extensions/ArticleFeedbackv5/sql/alter.sql
@@ -45,3 +45,6 @@
4646 ALTER TABLE aft_article_revision_feedback_select_rollup ADD PRIMARY KEY (arfsr_page_id, arfsr_field_id, arfsr_revision_id, arfsr_option_id);
4747 ALTER TABLE aft_article_revision_feedback_ratings_rollup DROP PRIMARY KEY;
4848 ALTER TABLE aft_article_revision_feedback_ratings_rollup ADD PRIMARY KEY (afrr_page_id, afrr_field_id, afrr_revision_id);
 49+
 50+-- added 12/16 (Roan)
 51+ALTER TABLE aft_article_feedback MODIFY COLUMN af_user_ip varchar(32) NULL;

Status & tagging log