r106379 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106378‎ | r106379 | r106380 >
Date:21:53, 15 December 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow-up r106189. The $wgUser are no longer needed.
Modified paths:
  • /trunk/phase3/includes/FeedUtils.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FeedUtils.php
@@ -53,8 +53,6 @@
5454 * @return String
5555 */
5656 public static function formatDiff( $row ) {
57 - global $wgUser;
58 -
5957 $titleObj = Title::makeTitle( $row->rc_namespace, $row->rc_title );
6058 $timestamp = wfTimestamp( TS_MW, $row->rc_timestamp );
6159 $actiontext = '';
@@ -85,7 +83,7 @@
8684 * @return String
8785 */
8886 public static function formatDiffRow( $title, $oldid, $newid, $timestamp, $comment, $actiontext='' ) {
89 - global $wgFeedDiffCutoff, $wgLang, $wgUser;
 87+ global $wgFeedDiffCutoff, $wgLang;
9088 wfProfileIn( __METHOD__ );
9189
9290 # log enties
@@ -95,9 +93,9 @@
9694 $actiontext,
9795 Linker::formatComment( $comment ) ) ) ) . "</p>\n";
9896
99 - //NOTE: Check permissions for anonymous users, not current user.
100 - // No "privileged" version should end up in the cache.
101 - // Most feed readers will not log in anway.
 97+ // NOTE: Check permissions for anonymous users, not current user.
 98+ // No "privileged" version should end up in the cache.
 99+ // Most feed readers will not log in anway.
102100 $anon = new User();
103101 $accErrors = $title->getUserPermissionsErrors( 'read', $anon, true );
104102

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106189Remove users of deprecated User::getSkin().siebrand13:01, 14 December 2011

Status & tagging log