r106308 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106307‎ | r106308 | r106309 >
Date:02:29, 15 December 2011
Author:khorn
Status:deferred
Tags:fundraising 
Comment:
followup r106109
Removed a line that used to be assigning a value to the form_data (which is gone now), but which wasn't being used anywhere after that.
Also uncommenting a heredoc that I had accidentally committed in a commented state.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php
@@ -43,21 +43,21 @@
4444 * The default appeal
4545 *
4646 */
47 -// const DEFAULT_APPEAL = <<<HTML
48 -// <h2 id="appeal-head"> <span class="mw-headline" id="From_Wikipedia_programmer_Brandon_Harris">From Wikipedia programmer Brandon Harris</span></h2>
49 -// <div id="appeal-body" class="plainlinks">
50 -// <p>I feel like I'm living the first line of my obituary.</p>
51 -// <p>I don't think there will be anything else that I do in my life as important as what I do now for Wikipedia. We're not just building an encyclopedia, we're working to make people free. When we have access to free knowledge, we are better people. We understand the world is bigger than us, and we become infected with tolerance and understanding.</p>
52 -// <p>Wikipedia is the 5th largest website in the world. I work at the small non-profit that keeps it on the web. We don't run ads because doing so would sacrifice our independence. The site is not and should never be a propaganda tool.</p>
53 -// <p>Our work is possible because of donations from our readers. Will you help protect Wikipedia by donating $5, $10, $20 or whatever you can afford?</p>
54 -// <p>I work at the Wikimedia Foundation because everything in my soul tells me it's the right thing to do. I've worked at huge tech companies, doing some job to build some crappy thing that's designed to steal money from some kid who doesn't know it. I would come home from work crushed.</p>
55 -// <p>You might not know this, but the Wikimedia Foundation operates with a very small staff. Most other top-ten sites have tens of thousands of people and massive budgets. But they produce a fraction of what we pull off with sticks and wire.</p>
56 -// <p>When you give to Wikipedia, you're supporting free knowledge around the world. You're not only leaving a legacy for your children and for their children, you're elevating people around the world who have access to this treasure. You're assuring that one day everyone else will too.</p>
57 -// <p>Thank you,</p>
58 -// <p><strong>Brandon Harris</strong><br /></p>
59 -// <p>Programmer, Wikimedia Foundation</p>
60 -// </div>
61 -//HTML;
 47+ const DEFAULT_APPEAL = <<<HTML
 48+ <h2 id="appeal-head"> <span class="mw-headline" id="From_Wikipedia_programmer_Brandon_Harris">From Wikipedia programmer Brandon Harris</span></h2>
 49+ <div id="appeal-body" class="plainlinks">
 50+ <p>I feel like I'm living the first line of my obituary.</p>
 51+ <p>I don't think there will be anything else that I do in my life as important as what I do now for Wikipedia. We're not just building an encyclopedia, we're working to make people free. When we have access to free knowledge, we are better people. We understand the world is bigger than us, and we become infected with tolerance and understanding.</p>
 52+ <p>Wikipedia is the 5th largest website in the world. I work at the small non-profit that keeps it on the web. We don't run ads because doing so would sacrifice our independence. The site is not and should never be a propaganda tool.</p>
 53+ <p>Our work is possible because of donations from our readers. Will you help protect Wikipedia by donating $5, $10, $20 or whatever you can afford?</p>
 54+ <p>I work at the Wikimedia Foundation because everything in my soul tells me it's the right thing to do. I've worked at huge tech companies, doing some job to build some crappy thing that's designed to steal money from some kid who doesn't know it. I would come home from work crushed.</p>
 55+ <p>You might not know this, but the Wikimedia Foundation operates with a very small staff. Most other top-ten sites have tens of thousands of people and massive budgets. But they produce a fraction of what we pull off with sticks and wire.</p>
 56+ <p>When you give to Wikipedia, you're supporting free knowledge around the world. You're not only leaving a legacy for your children and for their children, you're elevating people around the world who have access to this treasure. You're assuring that one day everyone else will too.</p>
 57+ <p>Thank you,</p>
 58+ <p><strong>Brandon Harris</strong><br /></p>
 59+ <p>Programmer, Wikimedia Foundation</p>
 60+ </div>
 61+HTML;
6262
6363 ////////////////////////////////////////////////////////////////////////////
6464 //
@@ -73,9 +73,6 @@
7474 */
7575 protected function init() {
7676
77 - // Should process be deprecated?
78 - $this->getEscapedValue( 'process' ) = 'other';
79 -
8077 // Initialize the appeal
8178 $this->appeal = self::DEFAULT_APPEAL;
8279

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106109Data handling cleanup in DonationInterface, part 2 of [some]....khorn21:53, 13 December 2011

Status & tagging log