r106302 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106301‎ | r106302 | r106303 >
Date:02:06, 15 December 2011
Author:neilk
Status:ok
Tags:
Comment:
put bugzilla link and description into one string (description of form closer to the form itself). Fix misplaced comma.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.feedback.js (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -4630,18 +4630,18 @@
46314631 'newuserlog-byemail' => 'password sent by e-mail',
46324632
46334633 # Feedback
4634 -'feedback-note' => 'This form publicly posts a simple comment or suggestion to the page "[$2 $1]", along with your user name, browser version and operating system.',
4635 -'feedback-bugnote' => 'Or, you can [$1 post a technical bug report] instead.',
4636 -'feedback-subject' => 'Subject:',
4637 -'feedback-message' => 'Message:',
4638 -'feedback-cancel' => 'Cancel',
4639 -'feedback-submit' => 'Submit Feedback',
4640 -'feedback-adding' => 'Adding feedback to page...',
4641 -'feedback-error1' => 'Error: Unrecognized result from API',
4642 -'feedback-error2' => 'Error: Edit failed',
4643 -'feedback-error3' => 'Error: No response from API',
4644 -'feedback-thanks' => 'Thanks! Your feedback has been posted to the page "[$2 $1]".',
4645 -'feedback-close' => 'Done',
 4634+'feedback-bugornote' => 'If you are ready to describe a technical problem in detail please [$1 report a bug].
 4635+Otherwise, you can use the easy form below. Your comment will be added to the page "[$3 $2]", along with your username and what browser you are using.',
 4636+'feedback-subject' => 'Subject:',
 4637+'feedback-message' => 'Message:',
 4638+'feedback-cancel' => 'Cancel',
 4639+'feedback-submit' => 'Submit Feedback',
 4640+'feedback-adding' => 'Adding feedback to page...',
 4641+'feedback-error1' => 'Error: Unrecognized result from API',
 4642+'feedback-error2' => 'Error: Edit failed',
 4643+'feedback-error3' => 'Error: No response from API',
 4644+'feedback-thanks' => 'Thanks! Your feedback has been posted to the page "[$2 $1]".',
 4645+'feedback-close' => 'Done',
46464646 'feedback-bugcheck' => 'Great! Just check that it is not already one of the [$1 known bugs].',
46474647 'feedback-bugnew' => 'I checked. Report a new bug',
46484648
Index: trunk/phase3/resources/Resources.php
@@ -538,8 +538,7 @@
539539 'jquery.ui.dialog',
540540 ),
541541 'messages' => array(
542 - 'feedback-note',
543 - 'feedback-bugnote',
 542+ 'feedback-bugornote',
544543 'feedback-subject',
545544 'feedback-message',
546545 'feedback-cancel',
Index: trunk/phase3/resources/mediawiki/mediawiki.feedback.js
@@ -77,7 +77,7 @@
7878 .attr( { 'href': _this.title.getUrl(), 'target': '_blank' } )
7979 .css( { 'white-space': 'nowrap' } );
8080
81 - var $bugNoteLink = $( '<a></a>' ).attr( { 'href': '#', } ).click( function() { _this.displayBugs(); } );
 81+ var $bugNoteLink = $( '<a></a>' ).attr( { 'href': '#' } ).click( function() { _this.displayBugs(); } );
8282
8383 var $bugsListLink = $( '<a></a>' ).attr( { 'href': _this.bugsListLink, 'target': '_blank' } );
8484
@@ -86,11 +86,11 @@
8787 $( '<div class="feedback-mode feedback-form"></div>' ).append(
8888 $( '<small></small>' ).append(
8989 $( '<p></p>' ).msg(
90 - 'feedback-note',
 90+ 'feedback-bugornote',
 91+ $bugNoteLink,
9192 _this.title.getNameText(),
9293 $feedbackPageLink.clone()
93 - ),
94 - $( '<p></p>' ).msg( 'feedback-bugnote', $bugNoteLink )
 94+ )
9595 ),
9696 $( '<div style="margin-top:1em;"></div>' ).append(
9797 mw.msg( 'feedback-subject' ),

Status & tagging log