| Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js |
| — | — | @@ -1902,7 +1902,8 @@ |
| 1903 | 1903 | .attr( 'href', mw.msg( 'articlefeedbackv5-cta1-learn-how-url' ) ); |
| 1904 | 1904 | |
| 1905 | 1905 | // Fill in the link |
| 1906 | | - var edit_track_id = $.articleFeedbackv5.ctaName() + '-button-click-' + |
| | 1906 | + var edit_track_id = $.articleFeedbackv5.bucketName() + '-' + |
| | 1907 | + $.articleFeedbackv5.ctaName() + '-button-click-' + |
| 1907 | 1908 | ( $.articleFeedbackv5.inDialog ? 'overlay': 'bottom' ); |
| 1908 | 1909 | $block.find( '.articleFeedbackv5-cta-button' ) |
| 1909 | 1910 | .attr( 'href', $.articleFeedbackv5.editUrl( edit_track_id ) ); |
| — | — | @@ -1968,7 +1969,8 @@ |
| 1969 | 1970 | |
| 1970 | 1971 | // Fill in the button link |
| 1971 | 1972 | var learn_url = mw.msg( 'articlefeedbackv5-cta1-learn-how-url' ); |
| 1972 | | - var learn_track_id = $.articleFeedbackv5.ctaName() + '-button-click-' + |
| | 1973 | + var learn_track_id = $.articleFeedbackv5.bucketName() + '-' + |
| | 1974 | + $.articleFeedbackv5.ctaName() + '-button-click-' + |
| 1973 | 1975 | ( $.articleFeedbackv5.inDialog ? 'overlay': 'bottom' ); |
| 1974 | 1976 | $block.find( '.articleFeedbackv5-cta-button' ) |
| 1975 | 1977 | .attr( 'href', $.articleFeedbackv5.trackingUrl( learn_url, learn_track_id ) ); |
| — | — | @@ -2656,7 +2658,8 @@ |
| 2657 | 2659 | $.articleFeedbackv5.setDialogDimensions(); |
| 2658 | 2660 | |
| 2659 | 2661 | // Track the event |
| 2660 | | - $.articleFeedbackv5.trackClick( $.articleFeedbackv5.ctaName() + '-impression-' + |
| | 2662 | + $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-' + |
| | 2663 | + $.articleFeedbackv5.ctaName() + '-impression-' + |
| 2661 | 2664 | ( $.articleFeedbackv5.inDialog ? 'overlay' : 'bottom' ) ); |
| 2662 | 2665 | |
| 2663 | 2666 | $.articleFeedbackv5.nowShowing = 'cta'; |
| — | — | @@ -2911,7 +2914,8 @@ |
| 2912 | 2915 | if ( 'form' == $.articleFeedbackv5.nowShowing ) { |
| 2913 | 2916 | $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-overlay-close' ); |
| 2914 | 2917 | } else if ('cta' == $.articleFeedbackv5.nowShowing ) { |
| 2915 | | - $.articleFeedbackv5.trackClick( $.articleFeedbackv5.ctaName() + '-overlay-close' ); |
| | 2918 | + $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-' + |
| | 2919 | + $.articleFeedbackv5.ctaName() + '-overlay-close' ); |
| 2916 | 2920 | } |
| 2917 | 2921 | $.articleFeedbackv5.setLinkId( '0' ); |
| 2918 | 2922 | $.articleFeedbackv5.$dialog.find( '.articleFeedbackv5-tooltip' ).hide(); |
| — | — | @@ -2979,6 +2983,7 @@ |
| 2980 | 2984 | inDebug: { args: 0, ret: true }, |
| 2981 | 2985 | nowShowing: { args: 0, ret: true }, |
| 2982 | 2986 | prefix: { args: 1, ret: true }, |
| | 2987 | + bucketName: { args: 0, ret: true }, |
| 2983 | 2988 | addToRemovalQueue: { args: 1, ret: false }, |
| 2984 | 2989 | openAsModal: { args: 1, ret: false }, |
| 2985 | 2990 | closeAsModal: { args: 0, ret: true }, |
| Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js |
| — | — | @@ -28,7 +28,9 @@ |
| 29 | 29 | |
| 30 | 30 | // Click event |
| 31 | 31 | var clickFeedbackLink = function ( $link ) { |
| 32 | | - $aftDiv.articleFeedbackv5( 'trackClick', linkInfo[ $link.data( 'linkId' ) ].trackId ); |
| | 32 | + var tracking_id = $aftDiv.articleFeedbackv5( 'bucketName' ) + |
| | 33 | + linkInfo[ $link.data( 'linkId' ) ].trackId; |
| | 34 | + $aftDiv.articleFeedbackv5( 'trackClick', tracking_id ); |
| 33 | 35 | $aftDiv.articleFeedbackv5( 'openAsModal', $link ); |
| 34 | 36 | }; |
| 35 | 37 | |