r106170 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106169‎ | r106170 | r106171 >
Date:09:41, 14 December 2011
Author:hashar
Status:ok
Tags:
Comment:
Bug 32709: private Wiki users were always taken to Special:Badtitle on login

Follow up r104506 which fixed bug 32276
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/OutputPage.php
@@ -1940,7 +1940,7 @@
19411941 * Produce the stock "please login to use the wiki" page
19421942 */
19431943 public function loginToUse() {
1944 - global $wgUser;
 1944+ global $wgUser, $wgRequest;
19451945
19461946 if( $wgUser->isLoggedIn() ) {
19471947 $this->permissionRequired( 'read' );
@@ -1954,12 +1954,18 @@
19551955 $this->setRobotPolicy( 'noindex,nofollow' );
19561956 $this->setArticleFlag( false );
19571957
 1958+ $returnto = Title::newFromURL( $wgRequest->getVal( 'title', '' ) );
 1959+ $returntoquery = array();
 1960+ if( $returnto ) {
 1961+ $returntoquery = array( 'returnto' => $returnto->getPrefixedText() );
 1962+ }
 1963+
19581964 $loginTitle = SpecialPage::getTitleFor( 'Userlogin' );
19591965 $loginLink = $skin->link(
19601966 $loginTitle,
19611967 wfMsgHtml( 'loginreqlink' ),
19621968 array(),
1963 - array( 'returnto' => $this->getTitle()->getPrefixedText() ),
 1969+ $returntoquery,
19641970 array( 'known', 'noclasses' )
19651971 );
19661972 $this->addHTML( wfMsgWikiHtml( 'loginreqpagetext', $loginLink ) );
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -3,6 +3,17 @@
44 Security reminder: MediaWiki does not require PHP's register_globals
55 setting since version 1.2.0. If you have it on, turn it '''off''' if you can.
66
 7+== MediaWiki 1.17.2 ==
 8+
 9+????-??-??
 10+
 11+This is a maintenance release of the MediaWiki 1.17 branch.
 12+
 13+=== Changes since 1.17.1 ===
 14+
 15+* (32709) Private Wiki users were always taken to Special:Badtitle on login
 16+
 17+
718 == MediaWiki 1.17.1 ==
819
920 2011-11-24

Follow-up revisions

RevisionCommit summaryAuthorDate
r106171Bug 32709: private Wiki users were always taken to Special:Badtitle on login...hashar09:41, 14 December 2011
r106206MF REL1_18 to wmf...hashar15:54, 14 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104505* (bug 32276) Skins were generating output using the internal page title whic...reedy23:18, 28 November 2011
r104506* (bug 32276) Skins were generating output using the internal page title whic...reedy23:28, 28 November 2011
r104508* (bug 32276) Skins were generating output using the internal page title whic...reedy23:30, 28 November 2011
r104509* (bug 32276) Skins were generating output using the internal page title whic...reedy23:31, 28 November 2011

Status & tagging log