r106132 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106131‎ | r106132 | r106133 >
Date:23:39, 13 December 2011
Author:preilly
Status:ok
Tags:
Comment:
remove unneeded and commented out require statements
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -106,7 +106,7 @@
107107 }
108108
109109 class ExtMobileFrontend {
110 - const VERSION = '0.5.97';
 110+ const VERSION = '0.5.98';
111111
112112 /**
113113 * @var DOMDocument
@@ -798,13 +798,10 @@
799799 $submit = self::$messages['mobile-frontend-leave-feedback-submit'];
800800
801801 $feedbackPostURL = str_replace( '&mobileaction=leave_feedback', '', $wgRequest->getFullRequestURL() ) . '&mobileaction=leave_feedback_post';
802 - //require( 'views/layout/_search_webkit.html.php' );
803802 $searchTemplate = $this->getSearchTemplate();
804803 $searchWebkitHtml = $searchTemplate->getHTML();
805 - //require( 'views/layout/_footmenu_default.html.php' );
806804 $footerTemplate = $this->getFooterTemplate();
807 - $footerHtml = $footerTemplate->getHTML();
808 - //require( 'views/information/leave_feedback.html.php' );
 805+ $footerHtml = $footerTemplate->getHTML();
809806 $leaveFeedbackTemplate = new LeaveFeedbackTemplate();
810807 $options = array(
811808 'feedbackPostURL' => str_replace( '&mobileaction=leave_feedback', '', $wgRequest->getFullRequestURL() ) . '&mobileaction=leave_feedback_post',
@@ -819,7 +816,6 @@
820817 $leaveFeedbackTemplate->setByArray( $options );
821818 $leaveFeedbackHtml = $leaveFeedbackTemplate->getHTML();
822819 $contentHtml = $leaveFeedbackHtml;
823 - //require( 'views/layout/application.html.php' );
824820 $noticeHtml = ( !empty( $noticeHtml ) ) ? $noticeHtml : '';
825821 $applicationTemplate = $this->getApplicationTemplate();
826822 $options = array(
@@ -931,14 +927,10 @@
932928 $backButton = self::$messages['mobile-frontend-back-button'];
933929 $htmlTitle = $areYouSure;
934930 $title = $areYouSure;
935 - //require( 'views/layout/_search_webkit.html.php' );
936931 $searchTemplate = $this->getSearchTemplate();
937932 $searchWebkitHtml = $searchTemplate->getHTML();
938 - //require( 'views/layout/_footmenu_default.html.php' );
939933 $footerTemplate = $this->getFooterTemplate();
940934 $footerHtml = $footerTemplate->getHTML();
941 - //require( 'views/information/disable.html.php' );
942 -
943935 $disableTemplate = new DisableTemplate();
944936 $options = array(
945937 'currentURL' => self::$currentURL,
@@ -954,7 +946,6 @@
955947 $disableHtml = $disableTemplate->getHTML();
956948
957949 $contentHtml = $disableHtml;
958 - //require( 'views/layout/application.html.php' );
959950 $noticeHtml = ( !empty( $noticeHtml ) ) ? $noticeHtml : '';
960951 $applicationTemplate = $this->getApplicationTemplate();
961952 $options = array(
@@ -1454,7 +1445,6 @@
14551446 $contentHtml = $searchWml . $contentHtml;
14561447 // Content wrapping
14571448 $contentHtml = $this->createWMLCard( $contentHtml );
1458 - //require( 'views/layout/application.wml.php' );
14591449 $applicationWmlTemplate = new ApplicationWmlTemplate();
14601450 $options = array(
14611451 'mainPageUrl' => self::$mainPageUrl,

Status & tagging log