r106121 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106120‎ | r106121 | r106122 >
Date:22:57, 13 December 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
added missing db table indexes
Modified paths:
  • /trunk/extensions/Survey/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Survey/Survey.hooks.php (modified) (history)
  • /trunk/extensions/Survey/sql/AddMissingIndexes.sql (added) (history)

Diff [purge]

Index: trunk/extensions/Survey/sql/AddMissingIndexes.sql
@@ -0,0 +1,21 @@
 2+-- SQL for the Survey extension.
 3+-- Licence: GNU GPL v3+
 4+-- Author: Jeroen De Dauw < jeroendedauw@gmail.com >
 5+
 6+CREATE INDEX /*i*/surveys_survey_title ON /*_*/surveys (survey_title);
 7+CREATE INDEX /*i*/surveys_survey_enabled ON /*_*/surveys (survey_enabled);
 8+CREATE INDEX /*i*/surveys_survey_user_type ON /*_*/surveys (survey_user_type);
 9+CREATE INDEX /*i*/surveys_survey_ratio ON /*_*/surveys (survey_ratio);
 10+CREATE INDEX /*i*/surveys_survey_expiry ON /*_*/surveys (survey_expiry);
 11+CREATE INDEX /*i*/surveys_survey_min_pages ON /*_*/surveys (survey_min_pages);
 12+
 13+CREATE INDEX /*i*/survey_questions_survey_id ON /*_*/survey_questions (question_survey_id);
 14+CREATE INDEX /*i*/survey_questions_type ON /*_*/survey_questions (question_type);
 15+CREATE INDEX /*i*/survey_questions_required ON /*_*/survey_questions (question_required);
 16+CREATE INDEX /*i*/survey_questions_removed ON /*_*/survey_questions (question_removed);
 17+
 18+CREATE INDEX /*i*/survey_submissions_survey_id ON /*_*/survey_submissions (submission_survey_id);
 19+CREATE INDEX /*i*/survey_submissions_user_name ON /*_*/survey_submissions (submission_user_name);
 20+CREATE INDEX /*i*/survey_submissions_page_id ON /*_*/survey_submissions (submission_page_id);
 21+CREATE INDEX /*i*/survey_submissions_time ON /*_*/survey_submissions (submission_time);
 22+
Property changes on: trunk/extensions/Survey/sql/AddMissingIndexes.sql
___________________________________________________________________
Added: svn:eol-style
123 + native
Index: trunk/extensions/Survey/Survey.hooks.php
@@ -60,6 +60,14 @@
6161 dirname( __FILE__ ) . '/sql/Survey.sql',
6262 true
6363 ) );
 64+
 65+ $updater->addExtensionUpdate( array(
 66+ 'addIndex',
 67+ 'surveys',
 68+ '',
 69+ dirname( __FILE__ ) . '/sql/AddMissingIndexes.sql',
 70+ true
 71+ ) );
6472
6573 return true;
6674 }
Index: trunk/extensions/Survey/RELEASE-NOTES
@@ -10,6 +10,7 @@
1111 * Dropped compatibility with MediaWiki 1.17.
1212 * Use of RequestContext methods to get rid of globals.
1313 * Cleanup of database table index code.
 14+* Added missing database table indexes.
1415
1516 === Version 0.1.2 ===
1617 2011-11-14

Follow-up revisions

RevisionCommit summaryAuthorDate
r106125Follow up to r106121; add indexes to main sql file, failed earlier because I ...jeroendedauw23:18, 13 December 2011

Status & tagging log