r106083 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106082‎ | r106083 | r106084 >
Date:20:36, 13 December 2011
Author:jamesur
Status:ok
Tags:
Comment:
Self revert of r105408. Splitting up into 2 commits for merge sanity and make fixes to adapter changes
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php
@@ -160,19 +160,8 @@
161161 return $wgOut->redirect( $formAction );
162162 }
163163
164 - } elseif ( $payment_method == 'cash' ) {
165 -
 164+ } else {
166165 $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' );
167 -
168 - $formAction = $this->adapter->getTransactionDataFormAction();
169 -
170 - // Redirect to the bank
171 - if ( !empty( $formAction ) ) {
172 - return $wgOut->redirect( $formAction );
173 - }
174 -
175 - } else {
176 - $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' );
177166 }
178167
179168 return $this->resultHandler();
Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -314,7 +314,6 @@
315315 'SWIFTCODE' => 'swift_code',
316316 'TRANSACTIONTYPE' => 'transaction_type', // dd:GB,NL
317317 'ZIP' => 'zip',
318 - 'FISCALNUMBER' => 'fiscal_number', //Boletos
319318 );
320319 }
321320
@@ -630,13 +629,6 @@
631630 'label' => 'Real time bank transfer',
632631 'types' => array( 'rtbt_ideal', 'rtbt_eps', 'rtbt_sofortuberweisung', 'rtbt_nordea_sweden', 'rtbt_enets', ),
633632 );
634 -
635 - // Cash payments
636 - $this->payment_meathods['cash'] = array(
637 - 'label' => 'Cash payments',
638 - 'types' => array( 'cash_boleto', ),
639 - );
640 -
641633 }
642634
643635 /**
@@ -761,7 +753,6 @@
762754 'keys' => array(),
763755 );
764756
765 -
766757 /*
767758 * Direct debit
768759 *
@@ -977,16 +968,6 @@
978969 831 => 'Sparda-Bank',
979970 )
980971 );
981 -
982 - // Cash Payments - Boletos
983 -
984 - $this->payment_submeathods['cash_boleto'] = array(
985 - 'paymentproductid' => 1503,
986 - 'label' => 'Boleto Bancario Brazil',
987 - 'group' => 'cash',
988 - 'validation' => array(),
989 - 'keys' => array(),
990 - );
991972 }
992973
993974 /**
@@ -1972,14 +1953,6 @@
19731954 $this->setupStagePaymentMethodForEWallets( $payment_submethod, $type);
19741955 break;
19751956
1976 - /* Cash payments */
1977 - case 'cash_boleto':
1978 - $this->staged_data['payment_product'] = $this->payment_submethods[ $payment_submethod ]['paymentproductid'];
1979 - $this->var_map['PAYMENTPRODUCTID'] = 'payment_product';
1980 -
1981 - $this->addKeyToTransaction('FISCALNUMBER');
1982 - break;
1983 -
19841957 /* Online bank transfer */
19851958 case 'bpay':
19861959 $this->staged_data['payment_product'] = $this->payment_submethods[ $payment_submethod ]['paymentproductid'];
Index: trunk/extensions/DonationInterface/gateway_common/interface.i18n.php
@@ -343,7 +343,7 @@
344344 'donate_interface-bt-country_description' => 'Country description',
345345 'donate_interface-bt-payment_reference' => 'Payment reference',
346346 'donate_interface-bt-swift_code' => 'Swift code',
347 - 'donate_interface-bt-special_id' => 'Country specific information',
 347+ 'donate_interface-bt-special_id' => 'Special ID',
348348 'donate_interface-bt-information' => 'Bank transfer information',
349349 'donate_interface-bt-finished' => 'Finished',
350350
@@ -413,7 +413,6 @@
414414
415415 // HTTP errors
416416 'donate_interface-error-http-403' => 'You do not have permission to access this page.',
417 -
418417 );
419418
420419 /** Message documentation (Message documentation)
@@ -758,7 +757,7 @@
759758 'donate_interface-bt-country_description' => 'Bank transfer: Country description',
760759 'donate_interface-bt-payment_reference' => 'Bank transfer: Payment reference',
761760 'donate_interface-bt-swift_code' => 'Bank transfer: Swift code',
762 - 'donate_interface-bt-special_id' => 'Bank transfer: Label for country specific bank transfer information (for example ABA number for the USA)',
 761+ 'donate_interface-bt-special_id' => 'Bank transfer: Special ID',
763762 'donate_interface-bt-information' => 'Bank transfer: Bank transfer information',
764763 'donate_interface-bt-finished' => 'Bank transfer: Finished - this is a link or a button to take the user to the Thank you page for their donation.',
765764 'donate_interface-obt-biller_id' => 'BPAY (Australian Online Bank Transfer) - The label for biller code',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105408Add Boletos and adjust wording for country specific bank transfer informationjamesur02:06, 7 December 2011

Status & tagging log