r106072 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106071‎ | r106072 | r106073 >
Date:19:58, 13 December 2011
Author:brion
Status:ok
Tags:
Comment:
bug 33035: Followup r105925: set to null rather than unset so we don't get an undefined property error later

Apparently the unset() in Language::setCode() could cause the later is_null check in getHtmlCode() to fail, though I could not reproduce it myself.
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
——@@ -3484,7 +3484,7 @@
34853485 public function setCode( $code ) {
34863486 $this->mCode = $code;
34873487 // Ensure we don't leave an incorrect html code lying around
3488 - unset( $this->mHtmlCode );
 3488+ $this->mHtmlCode = null;
34893489 }
34903490
34913491 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105925Followup r105812:...dantman20:09, 12 December 2011

Status & tagging log