r106067 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106066‎ | r106067 | r106068 >
Date:19:21, 13 December 2011
Author:gregchiasson
Status:ok
Tags:
Comment:
AFTv5 - fix error introduced in r105487, where I had the wrong callback keys in jquery requests - error, not failure.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -71,7 +71,7 @@
7272 }
7373 $( '#aft5-' + type + '-link-' + id ).text( mw.msg( msg ) );
7474 },
75 - 'failure': function ( data ) {
 75+ 'error': function ( data ) {
7676 $( '#aft5-' + type + '-link-' + id ).text( mw.msg( 'articlefeedbackv5-error-flagging' ) );
7777 }
7878 } );
@@ -115,7 +115,7 @@
116116 $( '#aft5-show-feedback' ).text( mw.msg( 'articlefeedbackv5-error-loading-feedback' ) );
117117 }
118118 },
119 - 'failure': function ( data ) {
 119+ 'error': function ( data ) {
120120 $( '#aft5-show-feedback' ).text( mw.msg( 'articlefeedbackv5-error-loading-feedback' ) );
121121 }
122122 } );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105487Translation of AFTv5 feedback page error messages, including moving error mes...gregchiasson23:32, 7 December 2011

Status & tagging log