r106060 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106059‎ | r106060 | r106061 >
Date:18:45, 13 December 2011
Author:rmoen
Status:ok
Tags:
Comment:
added comments for NobleCount callback parameter. followup to r104937
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js
@@ -341,6 +341,11 @@
342342 $( '#mw-moodBar-feedbackInput' )
343343 .NobleCount('#mw-moodBar-charCount', {
344344 max_chars:140,
 345+ /*
 346+ * Callbacks:
 347+ * function on_negative: called when text field is negative in remaining characters.
 348+ * @param t_obj is the text object. need to pass to the callback to add modifiers.
 349+ */
345350 on_negative: function( t_obj ) {
346351 $( t_obj )
347352 .addClass('mw-moodBar-feedback-invalid')
@@ -348,6 +353,10 @@
349354 .find('.mw-moodBar-formNote')
350355 .addClass('red-bold');
351356 },
 357+ /*
 358+ * function on_positive: called when text field has available remaining characters.
 359+ * @param t_obj is the text object. need to pass to the callback to add modifiers.
 360+ */
352361 on_positive: function( t_obj ) {
353362 $( t_obj )
354363 .removeClass( 'mw-moodBar-feedback-invalid')
Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
@@ -463,13 +463,22 @@
464464 .find('.fbd-response-text')
465465 .NobleCount('.fbd-response-charCount', {
466466 max_chars:5000,
467 - on_negative: function( t_obj ) {
 467+ /*
 468+ * Callbacks:
 469+ * function on_negative: called when text field is negative in remaining characters.
 470+ * @param t_obj is the text object. need to pass to the callback to add modifiers.
 471+ */
 472+ on_negative: function( t_obj ) {
468473 $( t_obj )
469474 .addClass('fbd-response-text-invalid')
470475 .prev()
471476 .find('span')
472477 .addClass('red-bold');
473478 },
 479+ /*
 480+ * function on_positive: called when text field has available remaining characters.
 481+ * @param t_obj is the text object. need to pass to the callback to add modifiers.
 482+ */
474483 on_positive: function( t_obj ) {
475484 $( t_obj )
476485 .removeClass( 'fbd-response-text-invalid')

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104937added response handling for blocked user on moodbar and feedback dashboard, i...rmoen01:39, 2 December 2011

Status & tagging log