r106051 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106050‎ | r106051 | r106052 >
Date:18:03, 13 December 2011
Author:robin
Status:ok
Tags:
Comment:
Bug 30182: add dir="auto" as a workaround for untranslated gadget descriptions
Modified paths:
  • /trunk/extensions/Gadgets/Gadgets_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Gadgets/Gadgets_body.php
@@ -67,7 +67,9 @@
6868 foreach ( $thisSection as $gadget ) {
6969 if ( $gadget->isAllowed( $user ) ) {
7070 $gname = $gadget->getName();
71 - $available[$gadget->getDescription()] = $gname;
 71+ # bug 30182: dir="auto" because it's often not translated
 72+ $desc = '<span dir="auto">' . $gadget->getDescription() . '</span>';
 73+ $available[$desc] = $gname;
7274 if ( $gadget->isEnabled( $user ) ) {
7375 $default[] = $gname;
7476 }

Status & tagging log