r106026 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106025‎ | r106026 | r106027 >
Date:15:14, 13 December 2011
Author:hashar
Status:ok
Tags:
Comment:
testswarm apache conf in /etc/apache2/conf.d now

This is how Debian package for web applications are usually doing it,
they are added to the site wide configuration. Server handling several
virtualhosts will have to add up their own configuration in
/etc/apache2/sites-available something we can do with puppet.

Bump version to 0.1.0-3
Modified paths:
  • /trunk/debs/testswarm/debian/changelog (modified) (history)
  • /trunk/debs/testswarm/debian/testswarm.postinst (modified) (history)
  • /trunk/debs/testswarm/debian/testswarm.postrm (modified) (history)

Diff [purge]

Index: trunk/debs/testswarm/debian/changelog
@@ -1,3 +1,11 @@
 2+testswarm (0.1.0-3) unstable; urgency=low
 3+ * symlink testswarm apache conf in /etc/apache2/conf.d just like other
 4+ Debian packages. Administration using virtual hosts will have to set
 5+ up their own configuration in /etc/apache2/sites-available then symlink
 6+ in /etc/apache2/sites-enabled.
 7+
 8+ -- Antoine Musso <amusso@wikimedia.org> Tue, 13 Dec 2011 15:12:14 +0000
 9+
210 testswarm (0.1.0-2) unstable; urgency=low
311 * symlink testswarm apache conf in /etc/apache2/sites-enabled
412
Index: trunk/debs/testswarm/debian/testswarm.postinst
@@ -29,8 +29,8 @@
3030 a2enmod rewrite
3131
3232 # Symlink default conf if there is none
33 -if [ ! -e "/etc/apache2/sites-enabled/testswarm.conf" ]; then
34 - ln -s /etc/testswarm/apache.conf /etc/apache2/sites-enabled/testswarm.conf
 33+if [ ! -e "/etc/apache2/conf.d/testswarm.conf" ]; then
 34+ ln -s /etc/testswarm/apache.conf /etc/apache2/conf.d/testswarm.conf
3535 fi
3636 invoke-rc.d apache2 reload || true
3737
Index: trunk/debs/testswarm/debian/testswarm.postrm
@@ -34,6 +34,8 @@
3535
3636 remove)
3737 # unlink testswarm apache conf and restart apache
 38+ # /etc/testswarm/apache.conf is still there though so local modification
 39+ # are kept :)
3840 if [ -L "/etc/apache2/conf.d/testswarm.conf" ]; then
3941 rm /etc/apache2/conf.d/testswarm.conf
4042 fi

Status & tagging log