r105982 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105981‎ | r105982 | r105983 >
Date:04:51, 13 December 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
rem use of escapeLocalURL
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_UploadWindow.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_UploadWindow.php
@@ -835,7 +835,7 @@
836836 $iw = wfMsgWikiHtml( 'ignorewarning' );
837837 $reup = wfMsgWikiHtml( 'reuploaddesc' );
838838 $titleObj = SpecialPage::getTitleFor( 'Upload' );
839 - $action = $titleObj->escapeLocalURL( 'action=submit' );
 839+ $action = htmlspecialchars( $titleObj->getLocalURL( 'action=submit' ) );
840840 $align1 = $wgContLang->isRTL() ? 'left' : 'right';
841841 $align2 = $wgContLang->isRTL() ? 'right' : 'left';
842842
@@ -965,7 +965,7 @@
966966
967967
968968 $titleObj = SpecialPage::getTitleFor( 'UploadWindow' );
969 - $action = $titleObj->escapeLocalURL();
 969+ $action = htmlspecialchars( $titleObj->getLocalURL() );
970970
971971 $encDestName = htmlspecialchars( $this->mDesiredDestName );
972972

Status & tagging log